Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1216] Add 24x24 icons #668

Merged
merged 3 commits into from
Sep 2, 2024
Merged

feat: [DX-1216] Add 24x24 icons #668

merged 3 commits into from
Sep 2, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 30, 2024 •
edited
Loading

Summary

  • added 24x24 icons
  • moved all icons list generation to the optimus_icons package as it makes more sense

Testing steps

None. Old icons should not be touched and added 24x24 variants of those icons.

Follow-up issues

Change the storybook All Icons story to just take the exposed list of icons from the optimus_icons package.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@github-actions GitHub Actions
Copy link
Contributor

⛔ PR has more than 500 additions. Split it into smaller PRs.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⛔ PR has more than 500 additions. Split it into smaller PRs.

@witwash witwash added the ignore-size Ignore the size of this PR label Aug 30, 2024
@witwash witwash marked this pull request as ready for review September 2, 2024 09:58
@witwash witwash requested a review from a team as a code owner September 2, 2024 09:58
@witwash witwash merged commit a940399 into master Sep 2, 2024
6 checks passed
@witwash witwash deleted the DX-1216 branch September 2, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil