Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DX-2051] Fix OptimusTab title overflow #666

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: [DX-2051] Fix OptimusTab title overflow #666

merged 1 commit into from
Sep 5, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 28, 2024 •
edited
Loading

Summary

  • fixed the horizontal overflow in tabs with long names

Testing steps

  1. Open Tabs story
  2. Check the visuals of the component. The long text should not overflow horizontally.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review August 28, 2024 10:37
@witwash witwash requested a review from a team as a code owner August 28, 2024 10:37
@witwash
Copy link
Contributor Author

witwash commented Sep 5, 2024

@chaeMil 👀

@witwash witwash merged commit a249be3 into master Sep 5, 2024
8 checks passed
@witwash witwash deleted the DX-2051 branch September 5, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil