feat!: Upgrade to DCM 1.21.0

[witwash]

Summary

• Upgraded to 1.21.0 (1.19 -> 1.20 was a pricing change version)
• fixed linter issues

New enabled rules:

• avoid-misused-set-literals
• avoid-suspicious-super-overrides
• dispose-class-fields

New unused rules:

• avoid-banned-names
• newline-before-method
• prefer-boolean-prefixes

Testing steps

None

Follow-up issues

None

Check during review

• Verify against Jira issue.
• Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
• Unused code removed.
• Build passing.
• Is it a bug fix? Check that it is covered by a proper test (unit or integration).

[ookami-kb]

prefer-boolean-prefixes

I think it's pretty useful and follows our convention.

newline-before-method

I would enable that.

[witwash]

I was doubting about those two. I'll have to do a breaking refactor in optimus because some parameters are not following this exact convention

[witwash]

Here is the list of the default prefixes defined in this rule: [is, are, was, were, has, have, had, can, should, will, do, does, did] do we want to add something? @alboiuvlad29 @chaeMil @ookami-kb

[alboiuvlad29]

On a side note would you be able to bump http in remote logger if you get the chance? It's quite outdated and forces us to override the version for kiosk. It also seems to keep throwing errors in development with not being able to find the domain.

[witwash]

@ookami-kb,
OK, so, I've done this one with 3 commits because it is a breaking change for optimus, but it is not breaking for remote_logger and kiosk_mode

[witwash]

Look like 1.21.1 is already out, but unused _ is still flagged. Oh well 😢

[ookami-kb]

Can we just add _ to ignored-names?

[witwash]

ignored-names is for methods

Set ignored-names (default is empty) to ignore specific function / method names.

I've tried, no luck

[ookami-kb]

Ok, I've reported it back to DCM, let's have it ignored for now.