Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump Flutter to 3.16.0 #472

Merged
merged 2 commits into from
Nov 28, 2023
Merged

ci: Bump Flutter to 3.16.0 #472

merged 2 commits into from
Nov 28, 2023

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Nov 21, 2023

Summary

  • bumped GH action Flutter version
  • fixed migration issues

Testing steps

  • WillPopScope is deprecated and replaced with the PopScope. There is an issue raised asking to preserve WillPopScope, but the outcome is not clear. Need to test if the back button press is acting as intended.

Follow-up issues

  • Material 3 is now enabled by default and we need to test if it is not bleeding through our component and everything is looking like it should. There is a possibility to disable Material 3 for the time, but Material 2 is going to be deprecated so it would just postpone possible issues.
  • feat!: Add new rules from Dart 3.2 #474

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@ookami-kb
Copy link
Contributor

ookami-kb commented Nov 21, 2023

There are also some lint rules updated in Dart 3.2, let's include them as well (or maybe in a separate PR?).

@witwash witwash marked this pull request as ready for review November 22, 2023 14:43
@witwash witwash requested a review from a team November 22, 2023 14:43
@witwash
Copy link
Contributor Author

witwash commented Nov 22, 2023

@ookami-kb rules are in separate PR: #474

@witwash
Copy link
Contributor Author

witwash commented Nov 27, 2023

@ookami-kb, ping

@ookami-kb
Copy link
Contributor

@witwash please update PR title to include the type. Also, would it be a breaking change to optimus?

@witwash witwash changed the title Migrate to Flutter 3.16.0 ci: Bump Flutter to 3.16.0 Nov 27, 2023
@witwash
Copy link
Contributor Author

witwash commented Nov 27, 2023

@ookami-kb, didn't notice, thanks for noting. Done 👍

@ookami-kb ookami-kb enabled auto-merge November 28, 2023 11:18
@ookami-kb ookami-kb merged commit a471309 into master Nov 28, 2023
5 checks passed
@ookami-kb ookami-kb deleted the update-flutter branch November 28, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants