Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update text input design #467

Merged
merged 3 commits into from
Oct 24, 2023
Merged

feat: Update text input design #467

merged 3 commits into from
Oct 24, 2023

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Oct 20, 2023 •
edited
Loading

Summary

  • updated OptimusInputField design
  • updated FieldWrapper design
Video
CleanShot.2023-10-20.at.15.20.49.mp4

Testing steps

  1. Open InputField (or any Field) story
  2. Interact with the component and check if all states are displayed correctly.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review October 24, 2023 05:52
@witwash witwash requested a review from a team October 24, 2023 05:52
@witwash witwash merged commit 5167e44 into master Oct 24, 2023
5 checks passed
@witwash witwash deleted the UX-263 branch October 24, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb