Adding projects for the Bizkaia fiscalization + autogenerated Dtos #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdallahbeshi
requested changes
Oct 3, 2023
src/Mews.Fiscalizations.All.sln
Outdated
Comment on lines
55
to
59
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Bizkaia", "Bizkaia", "{B33E5A1D-A667-477D-9AD8-1673192B71BB}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mews.Fiscalizations.Bizkaia", "Mews.Fiscalizations.Bizkaia\Mews.Fiscalizations.Bizkaia.csproj", "{145C287C-2D14-4B35-A73A-6A97ABBF3F10}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mews.Fiscalizations.Bizkaia.Tests", "Mews.Fiscalizations.Bizkaia.Tests\Mews.Fiscalizations.Bizkaia.Tests.csproj", "{2767CE08-C4C2-4043-AC58-C413ECB64D3A}" |
There was a problem hiding this comment.
If i remember correctly, Bizkaia and the other 2 regions share most of the stuff (almost identical XSDs)
so i suggest that we either implement Bizkaia within the same project (Basque), or rename the Basque project to something else like GipuzkoaAndAraba, or having a project per region.
I would go with the first solution (all regions within 1 project).
There was a problem hiding this comment.
Ok, I will go with option 1 and have all regions in the same project..
src/Mews.Fiscalizations.Bizkaia.Tests/Mews.Fiscalizations.Bizkaia.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Mews.Fiscalizations.Bizkaia.Tests/Mews.Fiscalizations.Bizkaia.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Mews.Fiscalizations.Bizkaia.Tests/Mews.Fiscalizations.Bizkaia.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Mews.Fiscalizations.Bizkaia.Tests/Mews.Fiscalizations.Bizkaia.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Mews.Fiscalizations.Bizkaia.Tests/Mews.Fiscalizations.Bizkaia.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Mews.Fiscalizations.Bizkaia/Mews.Fiscalizations.Bizkaia.csproj
Outdated
Show resolved
Hide resolved
abdallahbeshi
requested changes
Oct 4, 2023
| "tidas_ConSG_AltaPeticion_V1_0_2.xsd")] | ||
| [XmlRoot(Namespace = "https://www.batuz.eus/fitxategiak/batuz/LROE/esquemas/LROE_PJ_240_1_1_FacturasEmi" + | ||
| "tidas_ConSG_AltaPeticion_V1_0_2.xsd", IsNullable = false)] | ||
| public class LROEPJ240FacturasEmitidasConSGAltaPeticion |
There was a problem hiding this comment.
Let's confirm with the research team that only model 240 is applicable in our case.
abdallahbeshi
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding autogenerated DTOS to support batuz fiscal integration.
Type of change
Checklist
A few other PRs will follow this one with models and unit tests to validate the DTOs.