Add batuz dtos #218
Closed
Add batuz dtos #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n integration. Adding Dtos for invoice request
abdallahbeshi
requested changes
Oct 3, 2023
abdallahbeshi
requested changes
Oct 3, 2023
Comment on lines
+1
to
+6
| using FuncSharp; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; |
Comment on lines
+14
to
+17
| private const string BatuzXsdFilename = @"./Xsd/LROE_PJ_240_1_1_FacturasEmitidas_ConSG_AltaPeticion_V1_0_2.xsd"; | ||
| private const string BatuzTiposComplejosFilename = @"./Xsd/batuz_TiposComplejos.xsd"; | ||
| private const string BatuzEnumeradosFilename = @"./Xsd/batuz_Enumerados.xsd"; | ||
| private const string BatuzTiposBasicosFilename = @"./Xsd/batuz_TiposBasicos.xsd"; |
There was a problem hiding this comment.
Redundant verbatim string prefix
Comment on lines
+20
to
+55
| public void CreateTBatuzInvoiceDto_XmlSerialization_Succeeds() | ||
| { | ||
| //Arrange create a dto that matches the samples provided by the Bizkaia authorities | ||
| var batuzInvoiceRequest = BatuzInvoiceRequestHelper.CreateSampleBatuzRequest(); | ||
|
|
||
| //act check that xml serialization of the ticketBai succeeds without errors | ||
| bool serializationSucceeds = XmlSerializationSucceeds(batuzInvoiceRequest, out XmlElement xmlElement); | ||
|
|
||
| //assert that xml serialization was possible | ||
| Assert.True(serializationSucceeds); | ||
| Assert.NotNull(xmlElement); | ||
| } | ||
|
|
||
| [Test] | ||
| public void CreateTicketBaiInvoice_XsdValidation_Succeeds() | ||
| { | ||
| //Arrange create a dto that matches the samples provided by the Bizkaia authorities | ||
| var batuzInvoiceRequest = BatuzInvoiceRequestHelper.CreateSampleBatuzRequest(); | ||
| var schemas = new Dictionary<string, string> | ||
| { | ||
| {"https://www.batuz.eus/fitxategiak/batuz/LROE/esquemas/LROE_PJ_240_1_1_FacturasEmitidas_ConSG_AltaPeticion_V1_0_2.xsd", BatuzXsdFilename }, | ||
| {"https://www.batuz.eus/fitxategiak/batuz/LROE/esquemas/batuz_TiposComplejos.xsd", BatuzTiposComplejosFilename }, | ||
| {"https://www.batuz.eus/fitxategiak/batuz/LROE/esquemas/batuz_Enumerados.xsd", BatuzEnumeradosFilename }, | ||
| {"https://www.batuz.eus/fitxategiak/batuz/LROE/esquemas/batuz_TiposBasicos.xsd", BatuzTiposBasicosFilename } | ||
| }; | ||
|
|
||
| //act check that xml serialization of the ticketBai succeeds without errors | ||
| bool serializationSucceeds = XmlSerializationSucceeds(batuzInvoiceRequest, out XmlElement xmlElement); | ||
| //assert that xml serialization was possible | ||
| Assert.True(serializationSucceeds); | ||
|
|
||
| bool xsdValidationSucceeds = XmlSchemaHelper.XmlSchemaValidationSucceeds(element: xmlElement, | ||
| validatingXsdFilename: BatuzXsdFilename, schemas); | ||
| Assert.True(xsdValidationSucceeds); | ||
|
|
||
| } |
There was a problem hiding this comment.
What's the purpose of these tests? wouldn't these test cases get covered later on when you create tests for sending an invoice? (like the other fiscalizations)?
and how frequently does these XSDs change? its just once when you import them, and if there will be an update one day, you will just import the new one and verify that your solution works using the other tests (like send_invoice_succeeds..etc)
Comment on lines
+1
to
+6
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Reflection.Metadata.Ecma335; | ||
| using System.Text; | ||
| using System.Threading.Tasks; |
Comment on lines
+1
to
+4
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Security; | ||
| using System.Xml.Serialization; |
Comment on lines
+12
to
+15
| private const string CorrectResponseFilename = @"./Documents/LROE_240_FacturasEmitidasConSG_Correcta.xml"; | ||
| private const string PartiallyCorrectResponseFilename = @"./Documents/LROE_240_FacturasEmitidasConSG_Parc_Correcta.xml"; | ||
| private const string IncorrectResponseFilename = @"./Documents/LROE_240_FacturasEmitidasConSG_Incorrecta.xml"; | ||
| private const string TicketBaiFilename = @"./Documents/ticketBai.xml"; |
There was a problem hiding this comment.
Redundant verbatim string prefix
Comment on lines
+57
to
+69
| private bool XmlSerializationSucceeds(LROEPJ240FacturasEmitidasConSGAltaPeticion batuzInvoiceRequest, out XmlElement? xmlElement) | ||
| { | ||
| try | ||
| { | ||
| xmlElement = XmlSerializationHelper<LROEPJ240FacturasEmitidasConSGAltaPeticion>.Serialize(batuzInvoiceRequest, Array.Empty<string>()); | ||
| return true; | ||
| } | ||
| catch | ||
| { | ||
| xmlElement = null; | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of all this, can't you just use Assert.DoesNotThrow?
|
|
||
| namespace Mews.Fiscalizations.Bizkaia.Tests | ||
| { | ||
| public static class XmlSerializationHelper<T> where T: class |
There was a problem hiding this comment.
Why not use the Xml helpers in the Core library?
| [Test] | ||
| public void CreateTicketBaiInvoice_XsdValidation_Succeeds() | ||
| { | ||
| //Arrange create a dto that matches the samples provided by the Bizkaia authorities |
There was a problem hiding this comment.
I wouldn't really add the AAA comments for every single test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented DTOS for the Batuz integration. Includes a preliminary version of the Models which will be improved in the future. Basic unit tests have been included to test: Dto serialization and deserialization (when applicable) and XSD validation.
Fixes https://mews.atlassian.net/browse/OPS-1744
Type of change
Checklist
Test cases: DTO serialization and deserialization, XSD validation after serializing.