Skip to content

Commit

Permalink
Feature/jlab menu customization (nebari-dev#2259)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelovilla authored Feb 19, 2024
2 parents 872f7bf + d11993e commit 195738e
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,40 @@
"@jupyterlab/mainmenu-extension:plugin": {
"menus": [
{
"id": "jp-mainmenu-nebari",
"disabled": false,
"label": "Nebari",
"rank": 1001,
"id": "jp-mainmenu-file",
"items": [
{
"command": "help:open",
"rank": 0,
"args": {
"url": "/hub/home",
"text": "Home",
"newBrowserTab": true
}
},
{
"type": "submenu",
"submenu": {
"id": "jp-mainmenu-file-new"
},
"rank": 0.5
},
{
"command": "hub:control-panel",
"rank": 0
"disabled": true
},
{
"command": "hub:logout",
"disabled": true
}
]
},
{
"id": "jp-mainmenu-services",
"disabled": false,
"label": "Services",
"rank": 1000,
"items": [
{
"command": "help:open",
"rank": 1,
Expand Down Expand Up @@ -61,6 +86,21 @@
}
}
]
},
{
"id": "jp-mainmenu-help",
"rank": 1001,
"items": [
{
"command": "help:open",
"rank": 1001,
"args": {
"url": "https://www.nebari.dev/docs/welcome/",
"text": "Nebari documentation",
"newBrowserTab": true
}
}
]
}
]
}
Expand Down
4 changes: 1 addition & 3 deletions tests/common/navigator.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,7 @@ def stop_server(self) -> None:
self.page.get_by_text("File", exact=True).click()

with self.context.expect_page() as page_info:
self.page.get_by_role(
"menuitem", name="Hub Control Panel", exact=True
).click()
self.page.get_by_role("menuitem", name="Home", exact=True).click()

home_page = page_info.value
home_page.wait_for_load_state()
Expand Down

0 comments on commit 195738e

Please sign in to comment.