Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fail Pipeline when Lint or Format issues #375

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Dec 19, 2024

The current Code Quality workflow action doesn't actually fail in the pipeline if there are issues due to the current scripts being set to fix the issues. This resolves that by adding npm scripts that perform just the check, not the fix.

Description

  • Added new ci scripts for lint and format
  • Updated code quality workflow action to run these scripts

Related Issue

  • N/A

Motivation and Context

  • Code Quality improvements

How Has This Been Tested?

  • Tested locally
  • Tested in the pipeline

Screenshots (if appropriate):

N/A

@jbouder jbouder added the ci Pipeline related updates label Dec 19, 2024
@jbouder jbouder changed the title Fix: Fail on Lint or Format Issues Fix: Fail on Lint and Format Dec 19, 2024
@jbouder jbouder changed the title Fix: Fail on Lint and Format Fix: Fail Pipeline when Lint or Format issues Dec 19, 2024
Copy link
Collaborator

@bapplejax bapplejax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbouder jbouder merged commit 7a380ca into main Dec 19, 2024
6 checks passed
@jbouder jbouder deleted the code-quality-fixes branch December 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Pipeline related updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants