Extended the server rules to use 'subscriptionParams' object. This ob… #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject may be provided in the settings->rule schema and enable sending the server subscription additional args within this object. In case a collection name is sent it will still send it (for backward compatability). However, in most of the production apps, a server subscription will be used, and it will enable sending additional args to the server (like token, etc) without breaking the API
|
Hey @TamarAmit, I apologize for the delay in responding. I don't have time to maintain this project anymore, so I gave you commit access to make any changes you'd like. It would be nice to follow the style used by the rest of the code and add some tests to this patch. If you'd like permission to publish the package to Meteor as well, please send me your Meteor username. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the server rules to use 'subscriptionParams' object. This object may be provided in the settings->rule schema and enable sending the server subscription additional args within this object. In case a collection name is sent it will still send it (for backward compatability). However, in most of the production apps, a server subscription will be used, and it will enable sending additional args to the server (like token, etc) without breaking the API