Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have dind use host's /etc/docker to ensure networks use safe subnets #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Have dind use host's /etc/docker to ensure networks use safe subnets #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ version number is tracked in the file `VERSION`.
## Unreleased
### Changed
- Small tidyups of environment collection module - PATCH
- Have dind use host's /etc/docker to ensure networks use safe subnets - MINOR
### Added
- Forward host working directory as `FLOKI_HOST_WORKDIR` - MINOR

Expand Down
2 changes: 2 additions & 0 deletions src/dind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ impl Dind {
"--name",
&self.name,
"-v",
"/etc/docker:/etc/docker:ro",
"-v",
&format!("{}:{}", self.mount_source, self.mount_target),
"-d",
"docker:stable-dind",
Expand Down