-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unmount Settings on blur to hide credential #8211
Conversation
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/514dd850-ff26-4ed1-a2d8-6fc0bc240d35 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8211 +/- ##
=======================================
Coverage 39.65% 39.65%
=======================================
Files 1233 1233
Lines 29820 29820
Branches 2840 2840
=======================================
Hits 11824 11824
Misses 17307 17307
Partials 689 689 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cbde6670-1eec-4208-aeab-aae5d233c786 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dd1efeba-3f83-4370-b7ab-0b0540acf5a7 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/15c4d0a0-496e-4d7a-acec-cb28fcd0797d |
Android builds are blocked atm #8220 (comment) |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea82cc72-4e1a-4564-8505-04e11866746d |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Currently there's an edge case that displays the seed phrase or private key without the use of password when the user tries to reveal the private key from the wallet view, this is caused by the screen not unmounting when changing tabs. The change in this PR sets a flag to unmount the Settings tab whenever the user navigates from it.
React Navigation source
Related issues
Fixes: #8210
Manual testing steps
Same steps as indicated in ticket #8210
Security & Privacy
Reveal Secret Recovery Phrase
Get started
Next
Hold to reveal SRP
Done
Show private key
Screenshots/Recordings
Before
Screen.Recording.2024-01-07.at.12.42.17.mov
After
Screen.Recording.2024-01-07.at.12.41.25.mov
Pre-merge author checklist
Pre-merge reviewer checklist