-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump keyring controller 7.5.0 #8035
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
d862696
to
522b894
Compare
…to feat/bump-keyring-controller-7.5.0
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8035 +/- ##
=======================================
Coverage 39.61% 39.61%
=======================================
Files 1233 1233
Lines 29830 29820 -10
Branches 2840 2840
=======================================
- Hits 11816 11814 -2
+ Misses 17321 17313 -8
Partials 693 693 ☔ View full report in Codecov by Sentry. |
…to feat/bump-keyring-controller-7.5.0
…to feat/bump-keyring-controller-7.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…om/MetaMask/metamask-mobile into feat/bump-keyring-controller-7.5.0
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2cebefad-8b8e-4a96-8668-da0b444a3ede |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
All tests have passed, all manual test cases were carried out using both OS Android 13 and iOS 17.1.1. |
Tested commit 28f05a6 with both Samsung A515f on Android 12 with fingerprint and iPhone 13 mini on iOS 15.6.2 with faceID. Tested the following with no issues:
|
Description
This PR bumps the
@metamask/keyring-controller
version from6.0.0
to7.5.0
. These are the relevant changes to take into consideration during review,keyringTypes
property from the KeyringController state (#1441)KeyringControllerOptions
type changed (#1441)KeyringControllerOptions.state
accepted type is now{ vault?: string }
KeyringControllerOptions.keyringBuilders
type is now{ (): Keyring<Json>; type: string }[]
address
type accepted by theremoveAccount
method is nowHex
(#1441)signTypedMessage
method now returns aPromise<string>
(#1441)signTransaction
method now requires aTypedTransaction
from@ethereumjs/tx@^4
for thetransaction
argument, and returns aPromise<TxData>
(#1441)Keyring
type toKeyringObject
(#1441)addNewAccount
now throws if address of new account is not a hex string (#1441)exportSeedPhrase
now throws if first keyring does not have a mnemonic (#1441)verifySeedPhrase
now throws if HD keyring does not have a mnemonic (#1441)Related issues
Fixes: #8180
Manual testing steps
Use cases or flows to verify,
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist