-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: solana swap and bridge navigation #29705
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This reverts commit 5c940bf.
Builds ready [dab950d]
Page Load Metrics (1675 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the title need to change for Solana Swaps? Because it still says Bridge for me
@@ -331,7 +337,7 @@ const CoinButtons = ({ | |||
///: END:ONLY_INCLUDE_IF | |||
|
|||
const setCorrectChain = useCallback(async () => { | |||
if (currentChainId !== chainId) { | |||
if (currentChainId !== chainId && multichainChainId !== chainId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to Heyse's comment - can this be written with less negations for better readability?
Builds ready [38eb96e]
Page Load Metrics (1655 ± 59 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [2b1dd86]
Page Load Metrics (1644 ± 87 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Enables swap and bridge buttons for non-evm networks and makes both of those buttons navigate to the bridge interface. Also fences the feature behind a code fence at the build level.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist