-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use a dynamic interval value for smart transaction status polling #29703
Merged
+191
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
dan437
changed the title
7feat: Use a dynamic interval value for smart transaction status polling
feat: Use a dynamic interval value for smart transaction status polling
Jan 14, 2025
dan437
force-pushed
the
stx-status-refresh-rates
branch
2 times, most recently
from
January 15, 2025 14:10
eecd290
to
0463a4e
Compare
antonydenyer
approved these changes
Jan 15, 2025
klejeune
approved these changes
Jan 15, 2025
Builds ready [0463a4e]
Page Load Metrics (1628 ± 53 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
dan437
force-pushed
the
stx-status-refresh-rates
branch
from
January 15, 2025 16:16
0463a4e
to
62c1c36
Compare
Builds ready [62c1c36]
Page Load Metrics (1640 ± 27 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Jan 16, 2025
metamaskbot
added
the
release-12.11.1
Issue or pull request that will be included in release 12.11.1
label
Jan 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.11.1
Issue or pull request that will be included in release 12.11.1
team-transactions
Transactions team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to use a dynamic interval value for smart transaction status polling, which is returned by backend. That way we can easily change it if needed and use the most optimal value.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist