Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use a dynamic interval value for smart transaction status polling #29703

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jan 14, 2025

Description

We want to use a dynamic interval value for smart transaction status polling, which is returned by backend. That way we can easily change it if needed and use the most optimal value.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Make sure smart transactions are enabled in Advanced Settings
  2. Be on Ethereum Mainnet
  3. Submit a smart transaction
  4. Check that a network request for checking smart transaction status happens every second

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 requested a review from a team as a code owner January 14, 2025 16:06
@dan437 dan437 marked this pull request as draft January 14, 2025 16:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 changed the title 7feat: Use a dynamic interval value for smart transaction status polling feat: Use a dynamic interval value for smart transaction status polling Jan 14, 2025
@metamaskbot metamaskbot added the team-transactions Transactions team label Jan 14, 2025
@dan437 dan437 force-pushed the stx-status-refresh-rates branch 2 times, most recently from eecd290 to 0463a4e Compare January 15, 2025 14:10
@dan437 dan437 marked this pull request as ready for review January 15, 2025 14:10
@metamaskbot
Copy link
Collaborator

Builds ready [0463a4e]
Page Load Metrics (1628 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37819541568295142
domContentLoaded1463185216039546
load14791955162811153
domInteractive24217534823
backgroundConnect6103232311
firstReactRender16100502512
getState5401084
initialActions01000
loadScripts1063143212108440
setupStore69711
uiStartup17002281188717484
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 406 Bytes (0.00%)
  • common: 275 Bytes (0.00%)

@dan437 dan437 force-pushed the stx-status-refresh-rates branch from 0463a4e to 62c1c36 Compare January 15, 2025 16:16
@metamaskbot
Copy link
Collaborator

Builds ready [62c1c36]
Page Load Metrics (1640 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1549174116375124
domContentLoaded1533172416145426
load1553178816405727
domInteractive228636178
backgroundConnect86323168
firstReactRender1695453115
getState589192311
initialActions0693157
loadScripts1152134212155426
setupStore65412147
uiStartup17742416199320699
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 406 Bytes (0.00%)
  • common: 275 Bytes (0.00%)

@dan437 dan437 enabled auto-merge January 15, 2025 18:21
@dan437 dan437 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 6b765ba Jan 16, 2025
73 checks passed
@dan437 dan437 deleted the stx-status-refresh-rates branch January 16, 2025 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-12.11.1 Issue or pull request that will be included in release 12.11.1 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.1 Issue or pull request that will be included in release 12.11.1 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants