feat: Remove 'Improved transactions requests' toggle

[pedronfigueiredo]

Description

We recently enabled the transaction redesign for all users by default. We also migrated some existing e2e tests to corresponding e2e tests for redesigned flows.

This PR removes the toggle that allowed users to opt out of the redesigned confirmations. It also removes the e2e tests for old confirmation flows that are no longer visible in any scenario.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3030

Manual testing steps

1. Open experimental settings.
2. The option toggle shouldn't be there.
3. Create a new transaction confirmation
4. It should be redesigned.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [6919546]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1739 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	558	1989	1669	278	133
		domContentLoaded	1534	1914	1704	105	50
		load	1547	1987	1739	111	53
		domInteractive	25	200	48	41	20
		backgroundConnect	12	82	34	20	10
		firstReactRender	17	100	44	27	13
		getState	5	76	19	21	10
		initialActions	0	1	0	0	0
		loadScripts	1155	1482	1284	93	45
		setupStore	6	58	15	16	8
		uiStartup	1768	2675	2004	193	92

Bundle size diffs [🚀 Bundle size reduced!]

• background: -103.01 KiB (-1.77%)
• ui: 79 Bytes (0.00%)
• common: -358 Bytes (-0.00%)

[metamaskbot]

Builds ready [1d2f569]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1584 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1461	1887	1590	104	50
		domContentLoaded	1443	1824	1559	101	49
		load	1456	1888	1584	105	50
		domInteractive	20	108	37	23	11
		backgroundConnect	8	66	27	19	9
		firstReactRender	15	88	38	26	13
		getState	5	85	14	21	10
		initialActions	0	1	0	0	0
		loadScripts	1064	1368	1164	82	39
		setupStore	6	84	14	18	9
		uiStartup	1658	2198	1871	163	78

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 553 Bytes (0.01%)
• ui: -4.86 KiB (-0.06%)
• common: -475 Bytes (-0.01%)

[metamaskbot]

Builds ready [8e8b6c4]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1594 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1450	1806	1598	99	47
		domContentLoaded	1440	1785	1569	95	46
		load	1453	1807	1594	99	48
		domInteractive	21	100	34	18	8
		backgroundConnect	7	92	26	21	10
		firstReactRender	15	96	46	30	15
		getState	4	44	10	11	5
		initialActions	0	40	2	9	4
		loadScripts	1051	1343	1175	79	38
		setupStore	5	54	12	13	6
		uiStartup	1647	2191	1897	166	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 553 Bytes (0.01%)
• ui: -1015 Bytes (-0.01%)
• common: -475 Bytes (-0.01%)

[matthewwalsh0]

Minor, is there any need for this line and the complex cast if we only reference preferences?

[matthewwalsh0]

Minor, is delete a no-op if the property doesn't exist so could we remove the if?