feat: add sentry error logging to account syncing erroneous situations #29692

mathieuartu · 2025-01-14T11:23:19Z

Description

This PR adds Sentry logging for all account syncing erroneous situations calls. It also attaches context so we know more about these situations.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-14T11:23:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-01-14T11:24:55Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`+1`	1.06 MB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`+2`	1.09 MB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	1.49 MB	metamaskbot

View full report↗︎

mathieuartu · 2025-01-14T11:35:08Z

@metamaskbot update-policies

metamaskbot · 2025-01-14T11:48:17Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-14T12:28:58Z

Builds ready [aa68dd4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1784 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	371	2047	1720	334	160
		domContentLoaded	1471	1982	1755	118	57
		load	1542	2036	1784	123	59
		domInteractive	28	91	44	19	9
		backgroundConnect	9	89	32	25	12
		firstReactRender	16	98	46	29	14
		getState	5	65	19	20	10
		initialActions	0	1	0	0	0
		loadScripts	1030	1547	1316	108	52
		setupStore	6	86	16	21	10
		uiStartup	1816	2580	2063	177	85

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 41 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 33.49 KiB (0.40%)

app/scripts/metamask-controller.js

Prithpal-Sooriya · 2025-01-14T14:00:42Z

lavamoat/browserify/beta/policy.json

@@ -830,7 +830,7 @@
    "@metamask/keyring-controller>@metamask/eth-sig-util>@metamask/abi-utils": {
      "packages": {
        "@metamask/utils>@metamask/superstruct": true,
-        "@metamask/keyring-controller>@metamask/eth-sig-util>@metamask/abi-utils>@metamask/utils": true
+        "@metamask/keyring-controller>@metamask/utils": true


I don't see any changes here, seems to be a lavamoat policy re-ordering.

Prithpal-Sooriya · 2025-01-14T14:01:31Z

lavamoat/browserify/beta/policy.json

+    "@metamask/profile-sync-controller>@metamask/keyring-api": {
+      "packages": {
+        "@metamask/keyring-api>@metamask/keyring-utils": true,
+        "@metamask/utils>@metamask/superstruct": true,
+        "@metamask/profile-sync-controller>@metamask/keyring-api>@metamask/utils": true,
+        "@metamask/keyring-api>bech32": true
+      }
+    },


The new version of this controller updates the keyring API (v 13.0.0), which includes these underlying changes.

Prithpal-Sooriya · 2025-01-14T14:03:03Z

yarn.lock

-    "@metamask/keyring-api": "npm:^12.0.0"
-    "@metamask/keyring-controller": "npm:^19.0.2"
+    "@metamask/base-controller": "npm:^7.1.1"
+    "@metamask/keyring-api": "npm:^13.0.0"


bump of keyring API has prompted an update to the lavamoat policies.

feat: add sentry error logging to account syncing erroneous situations

b98e003

mathieuartu added the team-identity label Jan 14, 2025

mathieuartu self-assigned this Jan 14, 2025

mathieuartu added 2 commits January 14, 2025 12:26

fix: yarn dedupe

76cb017

Merge branch 'main' into feat/add-account-sync-error-logging

45e6200

Update LavaMoat policies

aa68dd4

cmd-ob approved these changes Jan 14, 2025

View reviewed changes

mathieuartu marked this pull request as ready for review January 14, 2025 12:40

mathieuartu requested review from a team as code owners January 14, 2025 12:40

Prithpal-Sooriya reviewed Jan 14, 2025

View reviewed changes

app/scripts/metamask-controller.js Show resolved Hide resolved

Prithpal-Sooriya reviewed Jan 14, 2025

View reviewed changes

Prithpal-Sooriya approved these changes Jan 14, 2025

View reviewed changes

mathieuartu added this pull request to the merge queue Jan 14, 2025

Merged via the queue into main with commit bbe8143 Jan 14, 2025
101 checks passed

mathieuartu deleted the feat/add-account-sync-error-logging branch January 14, 2025 14:39

github-actions bot locked and limited conversation to collaborators Jan 14, 2025

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add sentry error logging to account syncing erroneous situations #29692

feat: add sentry error logging to account syncing erroneous situations #29692

mathieuartu commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025

socket-security bot commented Jan 14, 2025 •

edited

Loading

mathieuartu commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

Prithpal-Sooriya Jan 14, 2025

Prithpal-Sooriya Jan 14, 2025 •

edited

Loading

Prithpal-Sooriya Jan 14, 2025

feat: add sentry error logging to account syncing erroneous situations #29692

feat: add sentry error logging to account syncing erroneous situations #29692

Conversation

mathieuartu commented Jan 14, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 14, 2025

socket-security bot commented Jan 14, 2025 • edited Loading

mathieuartu commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

Prithpal-Sooriya Jan 14, 2025

Choose a reason for hiding this comment

Prithpal-Sooriya Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Prithpal-Sooriya Jan 14, 2025

Choose a reason for hiding this comment

mathieuartu commented Jan 14, 2025 •

edited

Loading

socket-security bot commented Jan 14, 2025 •

edited

Loading

Prithpal-Sooriya Jan 14, 2025 •

edited

Loading