Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focused search field forces scroll #29676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jan 13, 2025

Description

The bridge page's input fields are auto-focused by default, which forces the AssetPicker's search input field to keep re-focusing when it's open. As a result, the asset list keeps scrolling up to the top of the modal.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1856

Manual testing steps

  1. Load bridge page
  2. Click src token picker and verify search input component is focused
  3. Scroll to bottom of asset list and wait a 5 or more seconds
  4. Verify that modal does not scroll back up to search input component

Screenshots/Recordings

Before

Screenshot 2025-01-13 at 2 36 23 PM

After

Screenshot 2025-01-13 at 2 35 33 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [2b6aa5d]
Page Load Metrics (1651 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33118151594299144
domContentLoaded1463179216248340
load1478182216519144
domInteractive2285422110
backgroundConnect7133242814
firstReactRender16170704421
getState56515189
initialActions01000
loadScripts1094133912226531
setupStore67111147
uiStartup167826032043263126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 9 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review January 13, 2025 23:36
@micaelae micaelae requested a review from a team as a code owner January 13, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants