Multichain API E2E Test: wallet_createSession called with an existing active session #29672
Conversation
| ...optionalScopes, | ||
| }, | ||
| isMultichainOrigin: false, | ||
| isMultichainOrigin, |
There was a problem hiding this comment.
To match description of the desired e2e test
When a dapp has an existing active session with scopes A, B & C and accounts W & X
And the dapp calls wallet_createSession with scopes C, D, E and accounts Y & Z
And the user confirms in the wallet (without editing permissions)
The old session permissions should be entirely overwritten by those requested in the new createSession request
I need to add these optional params for using multichain dapp, and more optional scopes
Even so, I thought for the sake of not bloating test code to keep new sessions to 2 new scopes instead of 3, and 1 new account instead of 2. Let me know if this should be religiously done for 3 new scopes and 2 new accounts.
| /** | ||
| * Then we make sure to deselect the existing session scopes, and create session with new scopes | ||
| */ | ||
| OLD_SCOPES.forEach( | ||
| async (scope) => | ||
| await driver.clickElement(`input[name="${scope}"]`), | ||
| ); |
There was a problem hiding this comment.
Because of how multichain test dapp is working with previously existing sessions, I decided to document the flow of this specific test mainly for this part where we explain why we need to click checkboxes for these old existing scopes (as they come pre-selected in the UI).
Thinking of providing clarity and context for the next person touching this if needed.
You guys think we should keep these or remove the comments ?
-- test: e2e test for wallet_createSession called with an existing active session;
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist