Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto sign-in for existing users #29654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Jan 13, 2025

Description

This PR adds an auto-sign-in mechanism.
Currently, users that upgraded from a pre-auth era version might meet the conditions for being signed-in, but aren't because we attached the sign-in mechanism to manual actions like toggling MetaMetrics or Profile Syncing.
This fixes that, by checking if conditions for signing-in are met every time the UI opens, and if so, dispatching the sign-in method from AuthenticationController

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sentry-io bot commented Jan 13, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/background.js

Function Unhandled Issue
setupController Error: NetworkController state is invalid: selectedNetworkClientId '3938de10-581d-4264-b8b0-51d33ce001... ...
Event Count: 27 Affected Users: 0

Did you find this useful? React with a 👍 or 👎

@mathieuartu mathieuartu self-assigned this Jan 13, 2025
@mathieuartu mathieuartu marked this pull request as ready for review January 13, 2025 11:39
@mathieuartu mathieuartu requested a review from a team as a code owner January 13, 2025 11:39
@metamaskbot
Copy link
Collaborator

Builds ready [b83be71]
Page Load Metrics (1757 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15602003176113967
domContentLoaded15481990171013665
load15572005175713766
domInteractive266936146
backgroundConnect9159443919
firstReactRender16114513416
getState56621189
initialActions01000
loadScripts11141466127610349
setupStore68614199
uiStartup179226862144291140
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 918 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants