fix: duplicate content in multiple pending connect confirmations

[matthewwalsh0]

Description

Fix duplicate content when there are multiple pending connect confirmations.

Caused by props being copied to state but not updated.

Related issues

Fixes: #29594

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [77cf52d]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1761 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1407	2255	1758	247	118
		domContentLoaded	1399	2153	1728	233	112
		load	1409	2254	1761	246	118
		domInteractive	16	126	43	27	13
		backgroundConnect	9	110	34	31	15
		firstReactRender	16	83	48	25	12
		getState	5	56	13	14	7
		initialActions	0	0	0	0	0
		loadScripts	999	1733	1288	217	104
		setupStore	6	54	11	10	5
		uiStartup	1580	2804	2005	296	142

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -173 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[dbrans]

Hey Matt, these changes look great! Could you add some tests for them when you get a chance?

[seaona]

I see the issue fixed, thank you @matthewwalsh0

queuing-connect.mp4