test: migrate more token tests and update related page objects #29651
+1,828
−1,518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dialog interactions
…tabs on confirmation page
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cmd-ob
changed the title
Builds ready [50f87f5]
Page Load Metrics (1617 ± 45 ms)
Bundle size diffs
|
metamaskbot
added
INVALID-PR-TEMPLATE
Builds ready [af93374]
Page Load Metrics (1816 ± 107 ms)
Bundle size diffs
|
…date mock price URLs
javiergarciavera
approved these changes
Jan 13, 2025
|
@cmd-ob There is lint and CI failure for the test could you please check. |
chloeYue
reviewed
Jan 13, 2025
Comment on lines
+36
to
+43
| async check_SuggestedTokensCount(expectedTokenCount: number) { | ||
| const multipleSuggestedTokens = await this.driver.findElements( | ||
| this.tokenListItem, | ||
| ); | ||
|
|
||
| // Confirm the expected number of tokens are present as suggested token list | ||
| assert.equal(multipleSuggestedTokens.length, expectedTokenCount); | ||
| } |
There was a problem hiding this comment.
Suggested change
| async check_SuggestedTokensCount(expectedTokenCount: number) { | |
| const multipleSuggestedTokens = await this.driver.findElements( | |
| this.tokenListItem, | |
| ); | |
| // Confirm the expected number of tokens are present as suggested token list | |
| assert.equal(multipleSuggestedTokens.length, expectedTokenCount); | |
| } | |
| async check_suggestedTokensCount( | |
| expectedTokenCount: number, | |
| ): Promise<void> { | |
| console.log( | |
| `Check ${expectedTokenCount} suggested tokens are displayed`, | |
| ); | |
| await this.driver.wait(async () => { | |
| const multipleSuggestedTokens = await this.driver.findElements( | |
| this.tokenListItem, | |
| ); | |
| return multipleSuggestedTokens.length === expectedTokenCount; | |
| }, 10000); | |
| } |
There was a problem hiding this comment.
i made a code suggestion to make the method more robust and mitigate flakiness
Comment on lines
+313
to
+318
| await this.driver.waitUntil( | ||
| async () => { | ||
| return await this.driver.isElementPresentAndVisible(this.priceChart); | ||
| }, | ||
| { timeout: 2000, interval: 100 }, | ||
| ); |
There was a problem hiding this comment.
small question: is there a reason why we don't use await driver.waitForSelector(this.priceChart); here?
hjetpoluru
reviewed
Jan 13, 2025
| css: 'p', | ||
| text: tEn('networkFee') as string, | ||
| }; | ||
| async confirmTx(): Promise<void> { |
There was a problem hiding this comment.
minor nit: could we have this as clickConfirmTx or clickConfirmButton
There was a problem hiding this comment.
Same question why there is duplicate function
hjetpoluru
reviewed
Jan 13, 2025
| * @param gasLimit - The gas limit value to set | ||
| * @param gasPrice - The gas price value to set | ||
| */ | ||
| async editGasFee(gasLimit: string, gasPrice: string): Promise<void> { |
There was a problem hiding this comment.
Why is the editGasFee duplicate function in all the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant improvements to the token-related E2E tests and page objects, focusing on better test coverage and maintainability. The changes include:
Enhanced token management functionality:
Test infrastructure improvements:
Code quality updates:
Related issues
N/A
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist