Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lint-workflows #29643

Merged
merged 3 commits into from
Jan 14, 2025
Merged

feat: lint-workflows #29643

merged 3 commits into from
Jan 14, 2025

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jan 10, 2025

Description

Open in GitHub Codespaces

This PR integrates the newly introduced lint-workflows reusable workflow to lint GitHub actions, replacing the previous hard-coded version with a reusable one.

Related issues

Contributes to: #28572

Manual testing steps

  1. Workflows should still be linted

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Jan 10, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [539029c]
Page Load Metrics (1758 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15712081176812259
domContentLoaded15302014173112258
load15382085175812962
domInteractive29175463216
backgroundConnect127230189
firstReactRender16111473115
getState572202311
initialActions00000
loadScripts10921587129111153
setupStore67916199
uiStartup174229292082277133
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

DDDDDanica
DDDDDanica previously approved these changes Jan 13, 2025
@DDDDDanica DDDDDanica enabled auto-merge January 13, 2025 17:52
davidmurdoch
davidmurdoch previously approved these changes Jan 13, 2025
@DDDDDanica DDDDDanica added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 13, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – only a hash changed since David approved.

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jan 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [c025aa3]
Page Load Metrics (1640 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14831831164311053
domContentLoaded14491819161711455
load14821830164011254
domInteractive27108502412
backgroundConnect56523168
firstReactRender1593462814
getState57314168
initialActions01000
loadScripts1066143312269646
setupStore674162110
uiStartup165423231984208100
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit df4458a Jan 14, 2025
80 checks passed
@itsyoboieltr itsyoboieltr deleted the feat/lint-workflows branch January 14, 2025 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants