fix: Fix LavaMoat build failures and restore RegExp OOM mitigation

[Gudahtt]

Description

LavaMoat was updated recently, but the patch we had of lavamoat-core was not updated with it. This restores the changes made in that patch.

Note that the old patch still exists because we're still using the older version of lavamoat-core for the lavamoat-viz tool.

The patch had three changes; the third was upstreamed already so it was not required, but the first two (RegExp cache and skipping policy write) were still required.

Related issues

Fixes #29482

Manual testing steps

There is no consistent way to test the intermittent build failure issue, though we could try running this over and over.

For the RegExp cache, we never had a clear reproduction for the OOM error that was meant to mitigate either.

Screenshots/Recordings

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

[Gudahtt]

The scuttling logic was refactored between these releases; it used to be in kernelCoreTempalte, but in v16 it was moved to scuttle.js. I had to move this cache along with it.

[Gudahtt]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [9d023d4]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1770 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	469	2196	1699	346	166
		domContentLoaded	1493	2151	1736	192	92
		load	1501	2166	1770	203	98
		domInteractive	22	80	39	18	8
		backgroundConnect	9	82	32	23	11
		firstReactRender	16	92	45	28	13
		getState	5	65	19	19	9
		initialActions	0	1	0	0	0
		loadScripts	1062	1620	1294	166	80
		setupStore	6	52	12	12	6
		uiStartup	1730	2575	2059	255	122

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)