Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runway #29632

Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat: runway #29632

merged 2 commits into from
Jan 13, 2025

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jan 10, 2025

Description

Open in GitHub Codespaces

This PR adds the Runway GitHub Action to help upload our builds and releases to Runway for easier release management. As Runway has a GitHub App connected to our repository, it is enough to upload builds as GitHub artifacts, and they will be automatically pulled. Currently the builds are downloaded from CircleCI, so later, once builds are migrated to GitHub Actions, this workflow will need to be updated.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3619

Manual testing steps

  1. Builds should show up in Runway.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Jan 10, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2ffb616]
Page Load Metrics (1645 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14751879164811957
domContentLoaded14641858161812158
load14731884164512359
domInteractive23187474019
backgroundConnect97731199
firstReactRender1595402613
getState45514157
initialActions01000
loadScripts10661418121611053
setupStore687182512
uiStartup164625341940224108
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 203 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b462c5c]
Page Load Metrics (1805 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15802299181316981
domContentLoaded15532096177814971
load15632123180515373
domInteractive248845199
backgroundConnect85924168
firstReactRender17102483215
getState56816178
initialActions01000
loadScripts10991624133614771
setupStore678282713
uiStartup173626392180256123
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0.00%)
  • ui: 203 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt
Copy link
Member

Gudahtt commented Jan 10, 2025

There is something odd about the .zip file artifacts. When testing, they work if I load the unzipped directories as an unpacked extension (in Chrome). But if I drag+drop the archive onto the extensions page, it fails. But the CircleCI artifact succeeds.

Something about the GitHub actions generated archive is different from the one we generate.

@Gudahtt
Copy link
Member

Gudahtt commented Jan 10, 2025

Looks like the issue was that it got double-zipped. See actions/upload-artifact#39

When unzipping the outer archive, the inner one works just as before. This should be OK, as long as we ensure we're not submitting the double-zipped file to the Chrome/Firefox stores in the publishing step.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DDDDDanica DDDDDanica added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 9380040 Jan 13, 2025
80 checks passed
@DDDDDanica DDDDDanica deleted the feat/runway branch January 13, 2025 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants