-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: runway #29632
feat: runway #29632
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2ffb616]
Page Load Metrics (1645 ± 59 ms)
Bundle size diffs
|
Builds ready [b462c5c]
Page Load Metrics (1805 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There is something odd about the .zip file artifacts. When testing, they work if I load the unzipped directories as an unpacked extension (in Chrome). But if I drag+drop the archive onto the extensions page, it fails. But the CircleCI artifact succeeds. Something about the GitHub actions generated archive is different from the one we generate. |
Looks like the issue was that it got double-zipped. See actions/upload-artifact#39 When unzipping the outer archive, the inner one works just as before. This should be OK, as long as we ensure we're not submitting the double-zipped file to the Chrome/Firefox stores in the publishing step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR adds the
Runway
GitHub Action to help upload our builds and releases to Runway for easier release management. As Runway has a GitHub App connected to our repository, it is enough to upload builds as GitHub artifacts, and they will be automatically pulled. Currently the builds are downloaded from CircleCI, so later, once builds are migrated to GitHub Actions, this workflow will need to be updated.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3619
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist