Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused end param in ethereum-chain-util helpers #29619

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 9, 2025

Description

Removes unused end param in the ethereum-chain-util helpers

  • validateChainId
  • validateAddEthereumChainParams
  • validateSwitchEthereumChainParams

Open in GitHub Codespaces

Extending E2E timeout to get past "no timings found" error:

flags = { "circleci": { "timeoutMinutes": 30 } }

Related issues

See: #27847 (comment)

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiexi jiexi enabled auto-merge January 9, 2025 21:51
@jiexi jiexi added this pull request to the merge queue Jan 9, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [1c7ec8c]
Page Load Metrics (1720 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23024001656380183
domContentLoaded14522350169219493
load14702405172020297
domInteractive24138432814
backgroundConnect77833199
firstReactRender1691362412
getState65614136
initialActions0442105
loadScripts10561832125617081
setupStore67214178
uiStartup166327331965238114

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@jiexi jiexi enabled auto-merge January 9, 2025 23:14
@jiexi jiexi added this pull request to the merge queue Jan 10, 2025
@Gudahtt
Copy link
Member

Gudahtt commented Jan 10, 2025

This was hitting E2E test timeouts due to lack of timing data, causing too many long e2e test suites to be allocated to a single runner.

I've added a flag to the PR description to extend the E2E test timeout, and it is passing now.

@metamaskbot
Copy link
Collaborator

Builds ready [313291f]
Page Load Metrics (1620 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14541843161811254
domContentLoaded14121789158811153
load14521851162011656
domInteractive20128442713
backgroundConnect115932178
firstReactRender156329199
getState56415168
initialActions01000
loadScripts1042136711889847
setupStore610811
uiStartup16472058181912359
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -8 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit f58258b Jan 10, 2025
83 checks passed
@jiexi jiexi deleted the jl/remove-unused-end-param-ethereum-chain-utils branch January 10, 2025 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants