-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unused end param in ethereum-chain-util helpers #29619
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [1c7ec8c]
Page Load Metrics (1720 ± 97 ms)
|
This was hitting E2E test timeouts due to lack of timing data, causing too many long e2e test suites to be allocated to a single runner. I've added a flag to the PR description to extend the E2E test timeout, and it is passing now. |
Builds ready [313291f]
Page Load Metrics (1620 ± 56 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Removes unused
end
param in the ethereum-chain-util helpersExtending E2E timeout to get past "no timings found" error:
Related issues
See: #27847 (comment)
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist