Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove second inner scroll bar from tx details (#29412) #29519

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Jan 8, 2025

Open in GitHub Codespaces

This PR cherry picks dabf173 into 12.10.0 RC

This PR removes the 2nd inner scrollbar from Bridge tx details.

Fixes:

  1. Do a bridge tx
  2. Get navigated to Activity list
  3. Click on a bridge tx
  4. Observe only 1 scroll bar

Screenshot 2024-12-20 at 5 03 15 PM

Screenshot 2024-12-20 at 5 19 06 PM

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29412?quickstart=1)

This PR removes the 2nd inner scrollbar from Bridge tx details.

Fixes:

1. Do a bridge tx
2. Get navigated to Activity list
3. Click on a bridge tx
4. Observe only 1 scroll bar

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

![Screenshot 2024-12-20 at 5 03
15 PM](https://github.com/user-attachments/assets/52904de2-7264-4959-bf23-6301eb1b7000)

<!-- [screenshots/recordings] -->

![Screenshot 2024-12-20 at 5 19
06 PM](https://github.com/user-attachments/assets/744401eb-80bf-4726-8ee4-844068a54978)

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review January 8, 2025 18:05
@infiniteflower infiniteflower requested a review from a team as a code owner January 8, 2025 18:05
@metamaskbot
Copy link
Collaborator

Builds ready [300cb13]
Page Load Metrics (1799 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16111997180011354
domContentLoaded15851976176711455
load16182002179911153
domInteractive25110482311
backgroundConnect126035157
firstReactRender1687332311
getState481212211
initialActions01000
loadScripts1138151413209244
setupStore76318199
uiStartup18032649207920599
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.04 KiB (0.04%)
  • ui: -943 Bytes (-0.01%)
  • common: 646 Bytes (0.01%)

@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants