Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: NFT Grid View #29445

Merged
merged 103 commits into from
Jan 13, 2025
Merged

refactor: NFT Grid View #29445

merged 103 commits into from
Jan 13, 2025

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Jan 6, 2025

Description

Refactors the NFT experience into a grid view. This changes the way that we are logically considering NFTs in that they are no longer sublisted by category, but are rather displayed in a flat grid.

They should however, still be sorted by default by the NFT collection, meaning that NFTs from the same collection should appear next to eachother in the grid. More sorts and filters will be added incrementally.

Also extends an initial privacy mode implementation onto NFT grid, to quickly show/hide NFTs.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-247

Manual testing steps

  1. Ensure that NFTs render in a grid, and are responsive to different screen sizes.
  2. Ensure that grid looks good on extension view. When viewing and sending NFT
  3. Ensure that NFT detail view looks on par with existing implementation
  4. Display NFT Media and IPFS gateway settings should remain unchanged, and should behave nicely with privacy mode.

Screenshots/Recordings

Before

Screenshot 2025-01-09 at 6 14 55 PM

After

nft-grid.mov
Screen.Recording.2025-01-10.at.7.37.02.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits - first pass seems good!

@metamaskbot
Copy link
Collaborator

Builds ready [dd50a1b]
Page Load Metrics (1697 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34721931617323155
domContentLoaded15072182168015976
load15172196169715776
domInteractive24142422713
backgroundConnect97123178
firstReactRender1685402612
getState550995
initialActions01000
loadScripts10801595122913063
setupStore65211105
uiStartup16732489191717283
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 43 Bytes (0.00%)
  • ui: -6.91 KiB (-0.09%)
  • common: -4.81 KiB (-0.06%)

@metamaskbot
Copy link
Collaborator

Builds ready [1f840e7]
Page Load Metrics (1684 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15282014169012560
domContentLoaded15111979165212158
load15242010168412661
domInteractive228138199
backgroundConnect1065322010
firstReactRender1783422713
getState45114126
initialActions01000
loadScripts1111149412399947
setupStore66113157
uiStartup17182297191313565
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -7.11 KiB (-0.09%)
  • common: 0 Bytes (0.00%)

darkwing
darkwing previously approved these changes Jan 13, 2025
@gambinish gambinish dismissed stale reviews from darkwing and Prithpal-Sooriya via 097a251 January 13, 2025 19:15
@metamaskbot
Copy link
Collaborator

Builds ready [097a251]
Page Load Metrics (1596 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14411903160012761
domContentLoaded14341891158112560
load14381907159612761
domInteractive227735168
backgroundConnect8331584
firstReactRender1595442713
getState44614157
initialActions01000
loadScripts10251450116511153
setupStore65815188
uiStartup16922248186116077
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -6.94 KiB (-0.09%)
  • common: 81 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit e356f86 Jan 13, 2025
80 checks passed
@gambinish gambinish deleted the feat/nft-grid-view-v2 branch January 13, 2025 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants