-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: NFT Grid View #29445
Merged
Merged
refactor: NFT Grid View #29445
+956
−1,619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extension into feat/nft-grid-view-v1
Prithpal-Sooriya
previously approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits - first pass seems good!
ui/components/multichain/asset-picker-amount/asset-picker-modal/asset-picker-modal-nft-tab.tsx
Show resolved
Hide resolved
Builds ready [dd50a1b]
Page Load Metrics (1697 ± 76 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [1f840e7]
Page Load Metrics (1684 ± 61 ms)
Bundle size diffs
|
Prithpal-Sooriya
previously approved these changes
Jan 11, 2025
darkwing
reviewed
Jan 13, 2025
darkwing
reviewed
Jan 13, 2025
darkwing
previously approved these changes
Jan 13, 2025
OGPoyraz
reviewed
Jan 13, 2025
ui/pages/confirmations/components/confirm/info/shared/nft-send-heading/nft-send-heading.tsx
Outdated
Show resolved
Hide resolved
gambinish
dismissed stale reviews from darkwing and Prithpal-Sooriya
via
January 13, 2025 19:15
097a251
OGPoyraz
approved these changes
Jan 13, 2025
Builds ready [097a251]
Page Load Metrics (1596 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinnyhoward
approved these changes
Jan 13, 2025
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the NFT experience into a grid view. This changes the way that we are logically considering NFTs in that they are no longer sublisted by category, but are rather displayed in a flat grid.
They should however, still be sorted by default by the NFT collection, meaning that NFTs from the same collection should appear next to eachother in the grid. More sorts and filters will be added incrementally.
Also extends an initial privacy mode implementation onto NFT grid, to quickly show/hide NFTs.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-247
Manual testing steps
Screenshots/Recordings
Before
After
nft-grid.mov
Screen.Recording.2025-01-10.at.7.37.02.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist