Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: verify test dapp update works #29433

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Jan 6, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [88b52b6]
Page Load Metrics (1739 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33620081528477229
domContentLoaded15261998170912158
load15622012173912158
domInteractive25136492813
backgroundConnect773322010
firstReactRender167530199
getState45012126
initialActions01000
loadScripts1123146712669043
setupStore65819199
uiStartup17552305197115173

@metamaskbot
Copy link
Collaborator

Builds ready [1510e33]
Page Load Metrics (1684 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15552204168614569
domContentLoaded15082119165513665
load15552191168414168
domInteractive26214564723
backgroundConnect973302110
firstReactRender1698432814
getState67514189
initialActions01000
loadScripts11281629125511455
setupStore677252612
uiStartup177525282023235113

@metamaskbot
Copy link
Collaborator

Builds ready [73e48e5]
Page Load Metrics (1661 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32518541606308148
domContentLoaded1454180116358842
load1473182516618943
domInteractive2491372010
backgroundConnect77326188
firstReactRender1573392411
getState466222110
initialActions01000
loadScripts1041137112248239
setupStore6401073
uiStartup16452130187111455
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants