-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace local isSnapId
definition with isSnapId
from @metamask/snaps-utils
#29422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-snaps-platform
Snaps Platform team
INVALID-PR-TEMPLATE
PR's body doesn't match template
labels
Dec 25, 2024
Builds ready [1dd71a1]
Page Load Metrics (1863 ± 291 ms)
|
FrederikBolding
approved these changes
Jan 6, 2025
GuillaumeRx
approved these changes
Jan 6, 2025
NidhiKJha
approved these changes
Jan 6, 2025
matthewwalsh0
approved these changes
Jan 6, 2025
Builds ready [7baee13]
Page Load Metrics (1700 ± 84 ms)
|
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Jan 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
isSnapId
function from the@metamask/snaps-utils
package.Related issues
Fixes: #29280
Pre-merge author checklist
Pre-merge reviewer checklist