Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xchain linea bugs #29409

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: xchain linea bugs #29409

wants to merge 2 commits into from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 20, 2024

Description

Open in GitHub Codespaces

This PR fixes a couple of issues and does the following:

  1. Shows a loading spinner on the Bridge button after submitting
  2. Does not wait 5 sec to submit a bridge tx on Linea if there is no approval tx

Related issues

Fixes:

Manual testing steps

Gas token

  1. Start a bridge from Linea to any chain for ETH
  2. Observe that you are redirected to Activity page almost instantly

ERC20

  1. Start a bridge from Linea to any chain for an ERC20
  2. Observe that a loading spinner shows on the button
  3. Observe you are redirected to Activity page after 5 sec

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-20.at.4.08.00.PM.mov
Screen.Recording.2024-12-20.at.4.08.39.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower changed the title Fix/xchain linea fix: xchain linea bugs Dec 20, 2024
@infiniteflower infiniteflower marked this pull request as ready for review December 20, 2024 21:12
@infiniteflower infiniteflower requested a review from a team as a code owner December 20, 2024 21:12
@metamaskbot
Copy link
Collaborator

Builds ready [40994f4]
Page Load Metrics (1906 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16592218190717383
domContentLoaded16202187187116077
load16582276190618086
domInteractive27113422010
backgroundConnect8109383416
firstReactRender17178644120
getState6102303316
initialActions01000
loadScripts10561696139415876
setupStore781272713
uiStartup191730782389327157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 32 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants