-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Migrate lint CI steps #29371
ci: Migrate lint CI steps #29371
Conversation
Builds ready [3fd4ff3]
Page Load Metrics (2092 ± 252 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
executor: shellcheck | ||
steps: | ||
- checkout | ||
- run: apk add --no-cache bash jq yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I think this is no longer needed because Github actions doesn't use Alpine linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, these are already included in the base Ubuntu image provided by GitHub Actions.
3fd4ff3
to
ab91b4a
Compare
Rebased to resolve conflicts |
Builds ready [ab91b4a]
Page Load Metrics (1802 ± 123 ms)
Bundle size diffs
|
Description
Migrate lint steps from CircleCI to GitHub Actions.
Related issues
Relates to #28572
These changes were extracted from #29256
Manual testing steps
Branch from here, create a new draft PR, Introduce lint errors, then ensure the jobs fail.
#29390
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist