Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate lint CI steps #29371

Merged
merged 1 commit into from
Dec 20, 2024
Merged

ci: Migrate lint CI steps #29371

merged 1 commit into from
Dec 20, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Description

Migrate lint steps from CircleCI to GitHub Actions.

Open in GitHub Codespaces

Related issues

Relates to #28572

These changes were extracted from #29256

Manual testing steps

Branch from here, create a new draft PR, Introduce lint errors, then ensure the jobs fail.
#29390

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [3fd4ff3]
Page Load Metrics (2092 ± 252 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34434061855676325
domContentLoaded148233662052515247
load150334162092524252
domInteractive24191713919
backgroundConnect7111372813
firstReactRender1577412210
getState56722199
initialActions01000
loadScripts109626461560419201
setupStore65916157
uiStartup172838332387641308
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 05:11
@Gudahtt Gudahtt requested a review from a team as a code owner December 20, 2024 05:11
@hjetpoluru hjetpoluru self-requested a review December 20, 2024 16:23
hjetpoluru
hjetpoluru previously approved these changes Dec 20, 2024
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

desi
desi previously approved these changes Dec 20, 2024
Copy link
Contributor

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

executor: shellcheck
steps:
- checkout
- run: apk add --no-cache bash jq yarn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I think this is no longer needed because Github actions doesn't use Alpine linux?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, these are already included in the base Ubuntu image provided by GitHub Actions.

Migrate lint steps from CircleCI to GitHub Actions.

Relates to #28572

These changes were extracted from #29256
@Gudahtt Gudahtt dismissed stale reviews from desi and hjetpoluru via ab91b4a December 20, 2024 18:56
@Gudahtt
Copy link
Member Author

Gudahtt commented Dec 20, 2024

Rebased to resolve conflicts

@metamaskbot
Copy link
Collaborator

Builds ready [ab91b4a]
Page Load Metrics (1802 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51527571730384184
domContentLoaded146826131765252121
load153626821802256123
domInteractive26170473215
backgroundConnect992413014
firstReactRender16101583014
getState682212411
initialActions01000
loadScripts108221591334233112
setupStore6105222814
uiStartup168429782169333160
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Dec 20, 2024
@hjetpoluru hjetpoluru self-requested a review December 20, 2024 19:47
Merged via the queue into main with commit 6f11eda Dec 20, 2024
77 checks passed
@Gudahtt Gudahtt deleted the migrate-linting branch December 20, 2024 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants