-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Migrate LavaMoat validation to GitHub Actions #29369
Merged
+97
−60
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Validate lavamoat allow scripts | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| validate-lavamoat-allow-scripts: | ||
| name: Validate lavamoat allow scripts | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@main | ||
|
|
||
| - name: Validate allow-scripts config | ||
| run: yarn allow-scripts auto | ||
|
|
||
| - name: Check working tree | ||
| run: | | ||
| if ! git diff --exit-code; then | ||
| echo "::error::Working tree dirty." | ||
| exit 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Validate lavamoat policy build | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| validate-lavamoat-policy-build: | ||
| name: Validate lavamoat policy build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@main | ||
|
|
||
| - name: Validate lavamoat build policy | ||
| run: yarn lavamoat:build:auto | ||
| env: | ||
| INFURA_PROJECT_ID: 00000000000 | ||
|
|
||
| - name: Check working tree | ||
| run: | | ||
| if ! git diff --exit-code; then | ||
| echo "::error::Working tree dirty." | ||
| exit 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Validate lavamoat policy webapp | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| validate-lavamoat-policy-webapp: | ||
| name: Validate lavamoat policy webapp | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| build-type: [main, beta, flask, mmi] | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@main | ||
|
|
||
| - name: Validate lavamoat ${{ matrix.build-type }} policy | ||
| run: yarn lavamoat:webapp:auto:ci --build-types=${{ matrix.build-type }} | ||
| env: | ||
| INFURA_PROJECT_ID: 00000000000 | ||
|
|
||
| - name: Check working tree | ||
| run: | | ||
| if ! git diff --exit-code; then | ||
| echo "::error::Working tree dirty." | ||
| exit 1 | ||
| fi | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an ENV var? or could you explain what that id is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! This is the single required environment variable for our build process. Generating an application LavaMoat policy requires building the project, so we needed to set it to something. But since this is a mock value that we don't want to use elsewhere, it's set inline directly.
The same strategy is used in the existing "Update LavaMoat policies" workflow:
metamask-extension/.github/workflows/update-lavamoat-policies.yml
Line 120 in 695d0db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Thanks for the explanation!