e2e testing: accounts requested in wallet_createSession#3822
#29356
+319
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamaskbot
added
team-wallet-api-platform
INVALID-PR-TEMPLATE
ffmcgee725
commented
Dec 19, 2024
ffmcgee725
commented
Dec 19, 2024
ffmcgee725
commented
Dec 19, 2024
ffmcgee725
commented
Dec 19, 2024
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
Comment on lines
81
to
85
| const requestScopesToNetworkMap = { | ||
| 'eip155:1': 'Ethereum Mainnet', | ||
| 'eip155:42161': 'Arbitrum One', | ||
| 'eip155:10': 'OP Mainnet', | ||
| }; |
There was a problem hiding this comment.
I think we may want to switch these over to ganache networks once those changes land
There was a problem hiding this comment.
Should we create a ticket to address this after those changes are delivered ?
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
jiexi
reviewed
Dec 20, 2024
jiexi
reviewed
Dec 20, 2024
jiexi
reviewed
Dec 20, 2024
jiexi
reviewed
Dec 20, 2024
adonesky1
reviewed
Dec 20, 2024
jiexi
approved these changes
Dec 20, 2024
ffmcgee725
merged commit ce3da8a
into
ad/multichain-api-e2e-test
59 of 66 checks passed
ffmcgee725
deleted the
jc/multichain-api-e2e-test-create-session-accounts-requested
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add e2e test for accounts requested in wallet_createSession