Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not re-load the whole confirmation when spending cap is changed #29347

Closed
wants to merge 5 commits into from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 19, 2024

Description

Currently almost whole of confirmation page re-loads when updating spending cap. This PR makes fix to load only specific sections when spending cap is updated.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3819

Manual testing steps

  1. Go to test dapp
  2. Create spending cap request
  3. Update spending cap - only specific section of the page should re-loas

Screenshots/Recordings

Screen.Recording.2024-12-19.at.4.39.34.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 19, 2024
@jpuri jpuri requested a review from a team as a code owner December 19, 2024 11:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

decimals={decimals || '0'}
setIsOpenEditSpendingCapModal={setIsOpenEditSpendingCapModal}
/>
)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the value above need to wait for pending to go away and not the whole component.

@metamaskbot
Copy link
Collaborator

Builds ready [c98aa1c]
Page Load Metrics (1618 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30518761563322154
domContentLoaded13101865158713565
load13151879161814168
domInteractive21129362411
backgroundConnect6157333316
firstReactRender1597403115
getState582252713
initialActions01000
loadScripts9691418118910952
setupStore681242612
uiStartup151925921985266128
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 96 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri enabled auto-merge December 19, 2024 12:50
@jpuri
Copy link
Contributor Author

jpuri commented Dec 19, 2024

CLosing the PR as issue is getting fixed by PR #29341

@jpuri jpuri closed this Dec 19, 2024
auto-merge was automatically disabled December 19, 2024 15:33

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants