Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Tooltip component to network icon of token-list-item #29336

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Dec 19, 2024

Description

Adds hover event on network icon on token-list-item to quickly show which network a token is on.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-476

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Screenshot 2024-12-18 at 4 10 07 PM Screenshot 2024-12-18 at 4 09 45 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review December 19, 2024 00:10
@gambinish gambinish requested a review from a team as a code owner December 19, 2024 00:10
@metamaskbot
Copy link
Collaborator

Builds ready [9aa4c8f]
Page Load Metrics (1514 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32516941409364175
domContentLoaded1352168815028541
load1360169215148641
domInteractive228841209
backgroundConnect85219126
firstReactRender1575362412
getState4409105
initialActions01000
loadScripts967125911007134
setupStore647994
uiStartup1570190917119445
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 118 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ad0c716]
Page Load Metrics (1732 ± 131 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint143024371744273131
domContentLoaded138023961707277133
load143224291732274131
domInteractive21136513216
backgroundConnect96025199
firstReactRender16101372512
getState667242010
initialActions01000
loadScripts99518611290248119
setupStore68013178
uiStartup164927772045347166
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 118 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d567eab]
Page Load Metrics (1770 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27019721704350168
domContentLoaded15161914174012861
load15561979177014067
domInteractive23156453216
backgroundConnect96834189
firstReactRender166925157
getState461212010
initialActions01000
loadScripts11461515132012761
setupStore66217178
uiStartup17362215199614771
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 118 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [2b4d0c1]
Page Load Metrics (1702 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15452030170712661
domContentLoaded15341978167611455
load15472029170212359
domInteractive207633147
backgroundConnect972272110
firstReactRender1699412713
getState55017167
initialActions01000
loadScripts11221482124410249
setupStore671252512
uiStartup173024802016228109
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 118 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants