-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update bottom border style for application header #29334
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
9a6cbac
Builds ready [9a6cbac]
Page Load Metrics (1777 ± 72 ms)
Bundle size diffs
|
@@ -100,10 +100,10 @@ describe('Test Snap Notification', function () { | |||
|
|||
// try to click on the account menu icon (via xpath) | |||
await driver.clickElement( | |||
'[data-testid="account-options-menu-button"]', | |||
'[data-testid="notifications-tag-counter__unread-dot"]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was complaining because the dot was obscuring the button
.multichain-app-header-shadow { | ||
box-shadow: var(--shadow-size-md) var(--color-shadow-default); | ||
.multichain-app-header-border { | ||
border-bottom: 1px solid var(--color-border-muted); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really confused by this change, we use box-shadow for other headers too, e.g. the Snaps confirmation headers. If anything this will make that feel more disconnected. I thought we were trying to use the box-shadow look everywhere?
Perhaps @eriknson can chime in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the issue for reference, I'm open to adding this elsewhere if we need to: #27313
Description
Changes bottom shadow of app header to a border-bottom as issue specifies.
Related issues
Fixes: #27313
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist