Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Network URL toPunycodeUrl preserve no path slash #29325

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Dec 18, 2024

Description

Open in GitHub Codespaces

Related issues

Related to: #29322

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4d6948e]
Page Load Metrics (1722 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27719981661345166
domContentLoaded14651952169713364
load14791968172214168
domInteractive268038147
backgroundConnect86127168
firstReactRender16106392713
getState578242110
initialActions01000
loadScripts11021446128010852
setupStore76118199
uiStartup165326392024226109
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 126 Bytes (0.00%)

@digiwand digiwand marked this pull request as ready for review December 19, 2024 14:16
@digiwand digiwand requested a review from a team as a code owner December 19, 2024 14:16
@digiwand digiwand added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit d4c5a73 Dec 20, 2024
85 checks passed
@digiwand digiwand deleted the fix-toPunycodeUrl-preserve-no-path-slash branch December 20, 2024 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants