Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate send erc20 to contract test #29321

Closed
wants to merge 14 commits into from

Conversation

cmd-ob
Copy link
Contributor

@cmd-ob cmd-ob commented Dec 18, 2024

Description

  • Moving test/e2e/tests/tokens/send-erc20-to-contract.spec.ts to use POM and TS
  • Add token overview page object
  • Add some new methods to send page

Related issues

Fixes:

Manual testing steps

All E2E tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Dec 18, 2024
@cmd-ob cmd-ob closed this Dec 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@cmd-ob cmd-ob deleted the qq-send-ecr20-to-contract branch December 20, 2024 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants