fix: Add origin pill to wallet_addEthereumChain confirmation #29317

pedronfigueiredo · 2024-12-18T12:09:24Z

Description

Adds Origin Pill component and references it on the confirmation template.

Related issues

Fixes: #26656

Manual testing steps

Go to the test dApp
Add a custom chain

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-18T12:09:41Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-18T12:42:42Z

Builds ready [42229a6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1686 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	210	1863	1540	432	207
		domContentLoaded	1485	1829	1667	101	48
		load	1497	1840	1686	97	47
		domInteractive	24	190	53	43	21
		backgroundConnect	8	78	24	22	10
		firstReactRender	16	93	56	26	12
		getState	4	59	9	12	6
		initialActions	0	1	0	0	0
		loadScripts	1081	1349	1226	92	44
		setupStore	6	53	14	15	7
		uiStartup	1766	2392	1942	147	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.85 KiB (0.02%)
common: 100 Bytes (0.00%)

metamaskbot · 2024-12-18T13:32:20Z

Builds ready [d61e63f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1763 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	246	2091	1603	482	231
		domContentLoaded	1450	2079	1736	200	96
		load	1456	2094	1763	207	99
		domInteractive	27	108	50	23	11
		backgroundConnect	8	137	30	37	18
		firstReactRender	16	101	56	31	15
		getState	4	93	17	23	11
		initialActions	0	1	0	0	0
		loadScripts	1007	1525	1271	156	75
		setupStore	7	76	21	22	11
		uiStartup	1646	2826	2122	296	142

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.85 KiB (0.02%)
common: 100 Bytes (0.00%)

matthewwalsh0 · 2024-12-18T16:04:01Z

ui/components/app/metamask-template-renderer/safe-component-list.js

@@ -86,6 +87,7 @@ export const safeComponentList = {
  Typography,
  SmartTransactionStatusPage,
  UrlIcon,
+  OriginPill,


You can see the moment we lost our beautiful alphabetical order 😄

matthewwalsh0 · 2024-12-18T16:04:54Z

ui/components/ui/origin-pill/origin-pill.js

Does this not already exist elsewhere that we can reuse, or is it part of another component?

This does not exist in this configuration. UrlIcon with a Text component exists elsewhere but it's not wrapped in its own component and has been deprecated.

matthewwalsh0 · 2024-12-18T16:05:01Z

ui/components/ui/origin-pill/origin-pill.js

TypeScript for all new components?

matthewwalsh0 · 2024-12-18T16:05:35Z

ui/components/ui/origin-pill/origin-pill.test.js

+      store,
+    );
+
+    expect(container).toMatchSnapshot();


Did we say we were going to avoid adding new snapshot tests?

Could we verify just the text itself for example?

matthewwalsh0 · 2024-12-19T11:24:49Z

ui/components/ui/origin-pill/origin-pill.tsx

+  );
+}
+
+OriginPill.propTypes = {


This is only needed for JS components so can be removed.

metamaskbot · 2024-12-19T12:11:37Z

Builds ready [22f0e33]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1665 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1430	2109	1672	190	91
		domContentLoaded	1388	2086	1652	192	92
		load	1396	2103	1665	195	94
		domInteractive	22	170	44	36	17
		backgroundConnect	9	94	17	19	9
		firstReactRender	16	77	44	25	12
		getState	5	58	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	994	1558	1219	169	81
		setupStore	6	59	18	19	9
		uiStartup	1639	2406	1913	211	101

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.86 KiB (0.02%)
common: 100 Bytes (0.00%)

metamaskbot · 2024-12-19T14:39:40Z

Builds ready [fa1ac36]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1648 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1412	2059	1655	173	83
		domContentLoaded	1403	2046	1624	172	83
		load	1414	2063	1648	180	86
		domInteractive	21	95	35	20	10
		backgroundConnect	9	64	27	19	9
		firstReactRender	15	82	36	24	12
		getState	5	63	16	16	8
		initialActions	0	1	0	0	0
		loadScripts	1012	1594	1215	141	68
		setupStore	6	60	13	15	7
		uiStartup	1578	2673	1880	259	124

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.68 KiB (0.02%)
common: 100 Bytes (0.00%)

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Dec 18, 2024

pedronfigueiredo self-assigned this Dec 18, 2024

pedronfigueiredo requested a review from a team as a code owner December 18, 2024 12:09

pedronfigueiredo changed the title ~~Add origin pill to wallet_addEthereumChain confirmation~~ fix: Add origin pill to wallet_addEthereumChain confirmation Dec 18, 2024

pedronfigueiredo force-pushed the pnf/26656 branch from 42229a6 to d61e63f Compare December 18, 2024 12:59

matthewwalsh0 requested changes Dec 18, 2024

View reviewed changes

pedronfigueiredo force-pushed the pnf/26656 branch from d61e63f to 22f0e33 Compare December 19, 2024 11:16

matthewwalsh0 previously approved these changes Dec 19, 2024

View reviewed changes

jpuri previously approved these changes Dec 19, 2024

View reviewed changes

pedronfigueiredo added 3 commits December 19, 2024 13:39

Add origin pill to wallet_addEthereumChain confirmation

d8608d1

Address PR review

db22caa

Address PR review

6bf8145

pedronfigueiredo dismissed stale reviews from jpuri and matthewwalsh0 via 6bf8145 December 19, 2024 13:39

pedronfigueiredo force-pushed the pnf/26656 branch from 22f0e33 to 6bf8145 Compare December 19, 2024 13:39

Address PR review

fa1ac36

jpuri approved these changes Dec 19, 2024

View reviewed changes

matthewwalsh0 approved these changes Dec 19, 2024

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Dec 19, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024

pedronfigueiredo added this pull request to the merge queue Dec 19, 2024

Merged via the queue into main with commit 09d4136 Dec 19, 2024
77 checks passed

pedronfigueiredo deleted the pnf/26656 branch December 19, 2024 16:52

github-actions bot locked and limited conversation to collaborators Dec 19, 2024

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add origin pill to wallet_addEthereumChain confirmation #29317

fix: Add origin pill to wallet_addEthereumChain confirmation #29317

pedronfigueiredo commented Dec 18, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

matthewwalsh0 Dec 18, 2024

pedronfigueiredo Dec 19, 2024

matthewwalsh0 Dec 18, 2024

pedronfigueiredo Dec 19, 2024

matthewwalsh0 Dec 18, 2024

matthewwalsh0 Dec 18, 2024

matthewwalsh0 Dec 19, 2024 •

edited

Loading

metamaskbot commented Dec 19, 2024

metamaskbot commented Dec 19, 2024

fix: Add origin pill to wallet_addEthereumChain confirmation #29317

fix: Add origin pill to wallet_addEthereumChain confirmation #29317

Conversation

pedronfigueiredo commented Dec 18, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

matthewwalsh0 Dec 18, 2024

Choose a reason for hiding this comment

pedronfigueiredo Dec 19, 2024

Choose a reason for hiding this comment

matthewwalsh0 Dec 18, 2024

Choose a reason for hiding this comment

pedronfigueiredo Dec 19, 2024

Choose a reason for hiding this comment

matthewwalsh0 Dec 18, 2024

Choose a reason for hiding this comment

matthewwalsh0 Dec 18, 2024

Choose a reason for hiding this comment

matthewwalsh0 Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Dec 19, 2024

metamaskbot commented Dec 19, 2024

pedronfigueiredo commented Dec 18, 2024 •

edited by github-actions bot

Loading

matthewwalsh0 Dec 19, 2024 •

edited

Loading