Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove use of boolean value for metrics properties #29315

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 18, 2024

Description

Remove use of boolean value for metrics property.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3811

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 18, 2024
@jpuri jpuri requested a review from a team as a code owner December 18, 2024 10:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fd0211b]
Page Load Metrics (1744 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15822309174716278
domContentLoaded14892298171116579
load15822314174416077
domInteractive27161463115
backgroundConnect1078332210
firstReactRender16102413014
getState681222412
initialActions01000
loadScripts10601720127013665
setupStore774232211
uiStartup177326662051256123
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 13 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@jpuri jpuri added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@jpuri jpuri added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit e87c714 Dec 18, 2024
83 checks passed
@jpuri jpuri deleted the metrics_fix branch December 18, 2024 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants