-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Token details should not display zero balance for tokens without marketData #29299
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined is the correct value, for instance when marketData doesn't exist
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: ui/components/app/wallet-overview/coin-buttons.tsx
Did you find this useful? React with a 👍 or 👎 |
bergeron
reviewed
Dec 17, 2024
Builds ready [d9c2791]
Page Load Metrics (1825 ± 89 ms)
Bundle size diffs
|
Builds ready [b2a79e5]
Page Load Metrics (1800 ± 75 ms)
Bundle size diffs
|
salimtb
approved these changes
Dec 18, 2024
Prithpal-Sooriya
approved these changes
Dec 18, 2024
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On main asset list, if a token doesn't have marketData, we do not display the fiat value. On tokenDetails we were falling back to zero balance (this is incorrect)
This PR adds a fix to not fallback to zero balance, and to instead simply omit the value.
Related issues
Fixes: #29244
Manual testing steps
NaN
value.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist