-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 29144 network switch failure handling #29295
Open
gambinish
wants to merge
13
commits into
main
Choose a base branch
from
fix/29144-network-switch-failure-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+188
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gambinish
changed the title
Fix/29144 network switch failure handling
fix: 29144 network switch failure handling
Dec 17, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…m:MetaMask/metamask-extension into fix/29144-network-switch-failure-handling
Builds ready [bb979b6]
Page Load Metrics (1559 ± 55 ms)
Bundle size diffs
|
Builds ready [a469076]
Page Load Metrics (1684 ± 97 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user is on the Asset page or Token Details page, and they try to send/swap a token on a network that isn't the globally selected network, we used to throw an error to stop execution and prevent a user from sending a token on the wrong network.
Instead of not handling that thrown error, this PR introduces some code to handle that case more gracefully. Rather than throwing an unhandled error, we instead pop a toast if there is an error in the
setCorrectChain
function, and make sure that we do not proceed with navigation if the failure exists.Related issues
Fixes: #29144
Manual testing steps
throw new Error('test error')
in try statement of setCorrectChain function oncoin-buttons.tsx
Screenshots/Recordings
Before
Screen.Recording.2024-12-17.at.1.09.48.PM.mov
After
Screen.Recording.2024-12-17.at.1.06.42.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist