Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix icon alignment in signature pages message section #29284

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 17, 2024

Description

Fix icon alignment in signature pages message section.

Related issues

Fixes: #28793

Manual testing steps

  1. Go to test dapp
  2. Submit permit
  3. Check expand and copy icons position in message section

Screenshots/Recordings

Screenshot 2024-12-17 at 9 06 53 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 17, 2024
@jpuri jpuri requested a review from a team as a code owner December 17, 2024 16:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo
Copy link
Contributor

Visually, the copy and expand button do not seem to be center aligned in the screenshot above

@metamaskbot
Copy link
Collaborator

Builds ready [23bbc8d]
Page Load Metrics (1757 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15652040175714369
domContentLoaded15552027172913565
load15652044175714168
domInteractive23102482311
backgroundConnect117426188
firstReactRender15190604321
getState666192010
initialActions01000
loadScripts11501538130110952
setupStore770192010
uiStartup178329552128316152
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -12 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit b018c81 Dec 18, 2024
77 checks passed
@jpuri jpuri deleted the sign_msg_section_design_fix branch December 18, 2024 10:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned button icons in Signature Message
5 participants