Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation between watch asset approvals #29279

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Dec 17, 2024

Description

Ignore any additional watch token and watch NFT approvals in the confirmation navigation, since both types of watch asset confirmation combine data from multiple approval requests.

Open in GitHub Codespaces

Related issues

Fixes: #29189

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 17, 2024
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review December 17, 2024 14:50
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners December 17, 2024 14:50
@metamaskbot
Copy link
Collaborator

Builds ready [1bb849f]
Page Load Metrics (1711 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34520841653321154
domContentLoaded14862072168011656
load15022089171111555
domInteractive177134115
backgroundConnect778332411
firstReactRender1672312110
getState55713147
initialActions01000
loadScripts11141608126110249
setupStore65616178
uiStartup17262347198415575
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 665 Bytes (0.01%)

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepytanya
Copy link
Contributor

Fixed:

Screen.Recording.2024-12-19.at.13.23.17.mov

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit fde9fa1 Dec 20, 2024
79 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/29189-watch-token-navigation branch December 20, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
6 participants