Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate portfolio e2e tests and permission requests tests to TS and Page Object Model #29274

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Dec 17, 2024

Description

  • Migrate portfolio e2e tests and permission requests e2e tests to TS and Page Object Model
test/e2e/tests/portfolio/portfolio-site.spec.ts
test/e2e/json-rpc/wallet_revokePermissions.spec.ts
test/e2e/json-rpc/wallet_requestPermissions.spec.ts
  • Remove unused ganach setup

Open in GitHub Codespaces

Related issues

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue requested a review from seaona December 17, 2024 13:17
@chloeYue chloeYue changed the title Porfolio tests test: Porfolio tests Dec 17, 2024
@chloeYue chloeYue marked this pull request as draft December 17, 2024 13:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title test: Porfolio tests test: Migrate portfolio e2e tests and permission requests tests to TS and Page Object Model Dec 17, 2024
@chloeYue chloeYue changed the title test: Migrate portfolio e2e tests and permission requests tests to TS and Page Object Model test: [POM] Migrate portfolio e2e tests and permission requests tests to TS and Page Object Model Dec 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b667ba6]
Page Load Metrics (1705 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40019861629306147
domContentLoaded13961942167913364
load14442000170512962
domInteractive2610439199
backgroundConnect86527189
firstReactRender1582432613
getState458202110
initialActions01000
loadScripts10121465124610751
setupStore68512178
uiStartup16292486198519091
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review December 17, 2024 17:04
@metamaskbot
Copy link
Collaborator

Builds ready [0dfc59b]
Page Load Metrics (1703 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36320821651343165
domContentLoaded14482063167617182
load14812082170317282
domInteractive24101442512
backgroundConnect117130199
firstReactRender1599433015
getState6159363718
initialActions01000
loadScripts10531584126214369
setupStore686232713
uiStartup167924292078246118
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as draft December 17, 2024 17:59
@chloeYue chloeYue marked this pull request as ready for review December 18, 2024 09:49
@metamaskbot
Copy link
Collaborator

Builds ready [8053e22]
Page Load Metrics (1878 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19622491555642308
domContentLoaded149922341850210101
load15542252187820599
domInteractive26114492512
backgroundConnect874282110
firstReactRender167131189
getState65520178
initialActions01000
loadScripts11081747138517383
setupStore76120199
uiStartup182424972146234113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@cmd-ob cmd-ob self-requested a review December 18, 2024 10:17
Copy link
Contributor

@cmd-ob cmd-ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 41b46a0 Dec 18, 2024
77 checks passed
@chloeYue chloeYue deleted the porfolio-tests branch December 18, 2024 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants