Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eth native icon for zora network #29257

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: add eth native icon for zora network #29257

merged 1 commit into from
Dec 18, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Dec 16, 2024

Description

The zora network uses ETH as its native token, so it can have an ETH icon.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add zora network
  2. Verify native eth asset has eth icon

Screenshots/Recordings

Before

Screenshot 2024-12-16 at 2 55 29 PM

After

Screenshot 2024-12-16 at 2 55 08 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [cd0acfd]
Page Load Metrics (1671 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25622101517451217
domContentLoaded13772191163717986
load13882213167117885
domInteractive23210434120
backgroundConnect991332311
firstReactRender1596442813
getState493172311
initialActions01000
loadScripts9891766122916780
setupStore67914189
uiStartup161126071988263127
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 19 Bytes (0.00%)

@bergeron bergeron enabled auto-merge December 17, 2024 20:03
@bergeron bergeron added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Dec 17, 2024
@bergeron bergeron added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit d630827 Dec 18, 2024
85 checks passed
@bergeron bergeron deleted the brian/l2-icons branch December 18, 2024 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants