refactor: shared bridge types

[micaelae]

Description

There is a lint rule that flags lines in which controllers and ui components import types/variables/methods from restricted directories. This change moves the imported elements to the shared directory to satisfy the linter. Also uses import type to remove type definitions from runtime bundles when possible

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1829

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

N/A

After

N/A - no functional changes

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [3d1be62]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1733 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	557	2043	1642	290	139
		domContentLoaded	1437	2281	1693	200	96
		load	1448	2291	1733	206	99
		domInteractive	24	100	40	20	10
		backgroundConnect	7	167	39	39	19
		firstReactRender	15	101	53	32	15
		getState	5	101	18	24	11
		initialActions	0	1	0	0	0
		loadScripts	1059	1517	1254	130	62
		setupStore	6	80	16	20	10
		uiStartup	1651	2534	2078	253	121

Bundle size diffs [🚀 Bundle size reduced!]

• background: 1.79 KiB (0.03%)
• ui: 9.06 KiB (0.11%)
• common: -11.18 KiB (-0.14%)

[infiniteflower]

Think you forgot to remove this comment?

[metamaskbot]

Builds ready [3708ad0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1633 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1487	1882	1635	119	57
		domContentLoaded	1436	1845	1608	111	54
		load	1486	1882	1633	120	58
		domInteractive	22	84	37	18	9
		backgroundConnect	9	76	33	21	10
		firstReactRender	16	103	48	31	15
		getState	5	88	15	24	11
		initialActions	0	1	0	0	0
		loadScripts	1041	1422	1198	104	50
		setupStore	6	86	17	23	11
		uiStartup	1692	2485	2010	234	112

Bundle size diffs [🚀 Bundle size reduced!]

• background: 1.79 KiB (0.03%)
• ui: 9.06 KiB (0.11%)
• common: -11.18 KiB (-0.14%)

[metamaskbot]

Builds ready [0b8d21c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1659 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1455	1861	1675	101	49
		domContentLoaded	1445	1750	1634	80	38
		load	1453	1790	1659	88	42
		domInteractive	25	114	58	31	15
		backgroundConnect	9	56	27	17	8
		firstReactRender	16	100	31	23	11
		getState	4	92	21	24	11
		initialActions	0	1	0	0	0
		loadScripts	1074	1326	1224	67	32
		setupStore	6	54	11	10	5
		uiStartup	1583	2154	1901	129	62

Bundle size diffs [🚀 Bundle size reduced!]

• background: 1.79 KiB (0.03%)
• ui: 9.13 KiB (0.11%)
• common: -11.25 KiB (-0.14%)