Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close network/accounts toasts when opening the Edit page #29239

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Dec 16, 2024

Description

This PR fixes the issue where toasts persist after navigating between Permissions view > Edit networks or Edit accounts. The fix ensures the toast dismisses upon navigating to edit in the Permissions modal.

Open in GitHub Codespaces

Related issues

Fixes: #27808

Manual testing steps

  1. Connect a dapp and grant permissions.
  2. Go to the Connection icon > Permissions view > Accounts > Edit.
  3. Change the account selection.
  4. Update and verify the toast confirms account permissions were updated.
  5. Navigate to Networks > Edit.
  6. Change the network selection.
  7. Update and verify the toast confirms network permissions were updated.
  8. Confirm no stale toast persists after each navigation.

Screenshots/Recordings

Before

Brave Browser 2024-10-11 at 4 24 18 PM

After

demo.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pulled and built the branch, ran the app, tested the code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@jonybur jonybur requested a review from a team as a code owner December 16, 2024 16:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b351d49]
Page Load Metrics (1689 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15152041169115575
domContentLoaded14811996166414771
load15082078168916077
domInteractive2698452110
backgroundConnect9129332914
firstReactRender1679442512
getState55315178
initialActions01000
loadScripts10821580123714369
setupStore66911136
uiStartup17252450193220096
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 90 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtherWizard33 EtherWizard33 self-requested a review December 18, 2024 15:11
Copy link

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonybur jonybur added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 86bd5dc Dec 18, 2024
77 checks passed
@jonybur jonybur deleted the jb-fix-27808 branch December 18, 2024 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dismiss toast on permissions modal
4 participants