Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use toUnicode function to normalize ens domains in the UI #29231

Merged
merged 8 commits into from
Dec 20, 2024
+5 −1
Merged

fix: Use toUnicode function to normalize ens domains in the UI #29231

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06b89eb
Use toUnicode function to normalize ens addresses
OGPoyraz Dec 16, 2024
bf16c20
Add ens casting in the deeper level
OGPoyraz Dec 16, 2024
c2bc8b5
Fix lint
OGPoyraz Dec 16, 2024
143deb9
Merge branch 'main' into 28610-bug-send-to-ens-emojis-domain---wrong-…
OGPoyraz Dec 16, 2024
825c14a
Add comment
OGPoyraz Dec 18, 2024
232b845
Merge branch 'main' into 28610-bug-send-to-ens-emojis-domain---wrong-…
OGPoyraz Dec 18, 2024
00d2693
Merge branch 'main' into 28610-bug-send-to-ens-emojis-domain---wrong-…
OGPoyraz Dec 19, 2024
d01b223
Merge branch 'main' into 28610-bug-send-to-ens-emojis-domain---wrong-…
OGPoyraz Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui/selectors/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { toUnicode } from 'punycode/punycode.js';
import { SubjectType } from '@metamask/permission-controller';
import { ApprovalType } from '@metamask/controller-utils';
import {
Expand Down Expand Up @@ -729,7 +730,10 @@ export function getAddressBook(state) {

export function getEnsResolutionByAddress(state, address) {
if (state.metamask.ensResolutionsByAddress[address]) {
return state.metamask.ensResolutionsByAddress[address];
const ensResolution = state.metamask.ensResolutionsByAddress[address];
// ensResolution is a punycode encoded string hence toUnicode is used to decode it from same package
const normalizedEnsResolution = toUnicode(ensResolution);
return normalizedEnsResolution;
}

const entry =
Expand Down
Loading